[docs] Add RTL documentation for the pickers #13855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-13855--material-ui-x.netlify.app/ Updated pages: |
flaviendelangle
commented
Jul 16, 2024
| const theme = React.useMemo( | ||
| () => createTheme({ direction: 'rtl' }, existingTheme), | ||
| () => createTheme(existingTheme, { direction: 'rtl' }), |
There was a problem hiding this comment.
The order was wrong, existingTheme contains direction"=ltr" so it overrode { direction: 'rtl' }
This, plus the missing stylis plugin meant that our UI was basically a mix of LTR and RTL on those demos.
oliviertassinari
added
the
component: pickers
flaviendelangle
commented
Aug 2, 2024
| @@ -397,11 +397,11 @@ export const MultiSectionDigitalClock = React.forwardRef(function MultiSectionDi | |||
| return views; | |||
| } | |||
| const digitViews = views.filter((v) => v !== 'meridiem'); | |||
| const result: TimeViewWithMeridiem[] = digitViews.toReversed(); | |||
| digitViews.reverse(); | |||
There was a problem hiding this comment.
.toReversed is too recent, I avoid using it.
It was causing the following issue in the CI when building the doc:
9:25:02 AM: TypeError: ec.filter(...).toReversed is not a function
There was a problem hiding this comment.
Circle CI is on Node 18, toReversed is Node 20.
flaviendelangle
force-pushed
the
rtl-doc
branch
from
0473a98 to
78798de
Compare
flaviendelangle
force-pushed
the
rtl-doc
branch
8 times, most recently
from
db1bbba to
24db72d
Compare
flaviendelangle
force-pushed
the
rtl-doc
branch
from
24db72d to
b14ce33
Compare
This was referenced Sep 27, 2024
This was referenced Oct 5, 2024
This was referenced Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11523
rtlPluginfrom stylis)dir="rtl"on pickers (the view are inside a portal, so they were not impacted by thedir="rtl"set in the demo)