[pickers] Keep the calendar header and content in sync when switching locale #14125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen switching locale
flaviendelangle
force-pushed
the
day-header-locale
branch
from
2910cc1 to
8497614
Compare
flaviendelangle
commented
Aug 6, 2024
| @@ -1,4 +1,5 @@ | |||
| import * as React from 'react'; | |||
| import moment, { Moment } from 'moment'; | |||
There was a problem hiding this comment.
Not related to this PR, I just noticed that we had 2 spec files for this component
| @@ -574,7 +574,7 @@ export function DayCalendar<TDate extends PickerValidDate>(inProps: DayCalendarP | |||
| key={i.toString()} | |||
| variant="caption" | |||
| role="columnheader" | |||
| aria-label={utils.format(utils.addDays(startOfCurrentWeek, i), 'weekday')} | |||
| aria-label={utils.format(weekday, 'weekday')} | |||
There was a problem hiding this comment.
No idea why we were re-doing the day shift here, but I spent some time finding out why my aria-label were not updated in the test whereas the UI was good in the doc 😆
|
Deploy preview: https://deploy-preview-14125--material-ui-x.netlify.app/ |
flaviendelangle
changed the title
flaviendelangle
force-pushed
the
day-header-locale
branch
from
841b7ae to
08e4fdf
Compare
flaviendelangle
force-pushed
the
day-header-locale
branch
from
08e4fdf to
4156d6c
Compare
zannager
added
the
component: pickers
LukasTy
reviewed
Sep 3, 2024
| @@ -574,7 +574,7 @@ export function DayCalendar<TDate extends PickerValidDate>(inProps: DayCalendarP | |||
| key={i.toString()} | |||
| variant="caption" | |||
| role="columnheader" | |||
| aria-label={utils.format(utils.addDays(startOfCurrentWeek, i), 'weekday')} | |||
| aria-label={utils.format(weekday, 'weekday')} | |||
This was referenced Sep 27, 2024
This was referenced Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12963
In
AdapterDateFnswe have the following:But on the adapters where the locale is stored on the date object, we didn't set the locale of the adapter to the value passed.
So if the locale of the value and the value of the adapter were different, it was the locale of the value that was being used.