Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Use event.key for Tab and Escape keys #14170

Merged
merged 3 commits into from
Aug 16, 2024
Merged

[core] Use event.key for Tab and Escape keys #14170

merged 3 commits into from
Aug 16, 2024

Conversation

k-rajat19
Copy link
Contributor

A little cleanup PR
we are already using event.key everywhere for different keys so why not for Tab andEscape keys ?

@zannager zannager added the component: data grid This is the name of the generic UI component, not the React module! label Aug 12, 2024
michelengelen
michelengelen approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@michelengelen michelengelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ... thanks for your contribution.

@romgrk romgrk enabled auto-merge (squash) August 16, 2024 22:02
@mui-bot
Copy link

mui-bot commented Aug 16, 2024

Deploy preview: https://deploy-preview-14170--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 8fcdcd9

@romgrk romgrk merged commit 70948f4 into mui:master Aug 16, 2024
16 checks passed
@oliviertassinari oliviertassinari added the core Infrastructure work going on behind the scenes label Aug 16, 2024
@oliviertassinari oliviertassinari changed the title [data grid] use event.key for Tab and Escape keys [core][data grid] Use event.key for Tab and Escape keys Aug 16, 2024
@oliviertassinari oliviertassinari changed the title [core][data grid] Use event.key for Tab and Escape keys [core] Use event.key for Tab and Escape keys Aug 16, 2024
@k-rajat19 k-rajat19 deleted the event-key branch August 17, 2024 05:48
@shagg0r shagg0r mentioned this pull request Sep 14, 2024
Open
@alhabib5565 alhabib5565 mentioned this pull request Sep 14, 2024
Open
@mbreadmachine mbreadmachine mentioned this pull request Sep 14, 2024
Closed
@KOTTAGENVH KOTTAGENVH mentioned this pull request Sep 15, 2024
Open
@alhabib5565 alhabib5565 mentioned this pull request Sep 18, 2024
Open
@KOTTAGENVH KOTTAGENVH mentioned this pull request Sep 18, 2024
Open
This was referenced Sep 19, 2024
Closed
Closed
This was referenced Sep 20, 2024
Open
Open
Open
Open
Open
@mbreadmachine mbreadmachine mentioned this pull request Sep 25, 2024
Closed
This was referenced Sep 27, 2024
Open
Open
Open
@oliviertassinari oliviertassinari mentioned this pull request Oct 1, 2024
Closed
This was referenced Oct 3, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michelengelen michelengelen michelengelen approved these changes

@romgrk romgrk romgrk approved these changes

@MBilalShafi MBilalShafi Awaiting requested review from MBilalShafi

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@k-rajat19 @mui-bot @romgrk @michelengelen @oliviertassinari @zannager