Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGridPremium] Fix onCellSelectionModelChange not triggered when additional cell range is selected #14199

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

arminmeh
Copy link
Contributor

Fixes #14184

Another reference is needed to detect the state change and trigger the event

@arminmeh arminmeh added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! plan: Premium Impact at least one Premium user feature: Cell Selection Related to the cell selection feature labels Aug 14, 2024
@mui-bot
Copy link

mui-bot commented Aug 14, 2024

Deploy preview: https://deploy-preview-14199--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 800d54f

@cherniavskii cherniavskii changed the title [DataGridPremium] onCellSelectionModelChange not triggered when additional cell range is selected [DataGridPremium] Fix onCellSelectionModelChange not triggered when additional cell range is selected Aug 21, 2024
@arminmeh arminmeh force-pushed the cell-selection-event-fix branch from 13c0a01 to 800d54f Compare August 21, 2024 19:12
@arminmeh arminmeh enabled auto-merge (squash) August 21, 2024 19:12
@arminmeh arminmeh merged commit 7aaecf5 into mui:master Aug 21, 2024
16 checks passed
@arminmeh arminmeh deleted the cell-selection-event-fix branch August 21, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Cell Selection Related to the cell selection feature plan: Premium Impact at least one Premium user
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[data grid] onCellSelectionModelChange not triggered when ctrl+dragging to select additional cells
3 participants