Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Include api in gridCellParams interface #14201

Merged
merged 5 commits into from
Aug 20, 2024
Merged

[DataGrid] Include api in gridCellParams interface #14201

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e852495
include api in gridCellParams
k-rajat19 Aug 14, 2024
935aed2
fix: make requested changes and fix sandbox errors
k-rajat19 Aug 14, 2024
d550622
Merge branch 'master' into issue-14190
k-rajat19 Aug 14, 2024
fc829c2
Merge remote-tracking branch 'upstream/master' into issue-14190
KenanYusuf Aug 20, 2024
3f81feb
run docs:api
KenanYusuf Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions packages/x-data-grid/src/components/cell/GridCell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import {
unstable_ownerDocument as ownerDocument,
unstable_capitalize as capitalize,
} from '@mui/utils';
import type { GridApiCommunity } from '../../internals';
import { fastMemo } from '../../utils/fastMemo';
import { doesSupportPreventScroll } from '../../utils/doesSupportPreventScroll';
import { getDataGridUtilityClass, gridClasses } from '../../constants/gridClasses';
Expand Down Expand Up @@ -75,9 +74,7 @@ export type GridCellProps = {
[x: string]: any; // TODO v7: remove this - it breaks type safety
};

type CellParamsWithAPI = GridCellParams<any, any, any, GridTreeNodeWithRender> & {
api: GridApiCommunity;
};
type CellParamsWithAPI = GridCellParams<any, any, any, GridTreeNodeWithRender>;
KenanYusuf marked this conversation as resolved.
Show resolved Hide resolved

const EMPTY_CELL_PARAMS: CellParamsWithAPI = {
id: -1,
Expand Down
4 changes: 4 additions & 0 deletions packages/x-data-grid/src/models/params/gridCellParams.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,10 @@ export interface GridCellParams<
* the tabIndex value.
*/
tabIndex: 0 | -1;
/**
* The api of `DataGrid`.
KenanYusuf marked this conversation as resolved.
Show resolved Hide resolved
*/
api: GridApiCommunity;
}

export interface FocusElement {
Expand Down
Loading