-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][pickers] Dash usage revision #14260
Merged
arthurbalduini
merged 1 commit into
mui:master
from
arthurbalduini:replaces-dashes-with-commas
Aug 20, 2024
Merged
[docs][pickers] Dash usage revision #14260
arthurbalduini
merged 1 commit into
mui:master
from
arthurbalduini:replaces-dashes-with-commas
Aug 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurbalduini
added
docs
Improvements or additions to the documentation
component: pickers
This is the name of the generic UI component, not the React module!
labels
Aug 19, 2024
arthurbalduini
requested review from
flaviendelangle,
LukasTy and
samuelsycamore
August 19, 2024 10:27
Deploy preview: https://deploy-preview-14260--material-ui-x.netlify.app/ Updated pages: |
Thank you for taking a look at this. 👍 |
samuelsycamore
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love seeing copyedits like this! 🎉 LGTM, thanks @arthurbalduini !
This was referenced Sep 19, 2024
This was referenced Sep 20, 2024
This was referenced Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: pickers
This is the name of the generic UI component, not the React module!
docs
Improvements or additions to the documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The usage of some dashes in the pickers docs seemed gramatically incorrect. This PR intends to improve it.