Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts] Improve bar chart performances #14278

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

alexfauquette
Copy link
Member

@alexfauquette alexfauquette commented Aug 21, 2024

Improve performances by removing the bar masks if the bar border-radius is not used

Plus it validate that codespeed is working correctly :)

image

@alexfauquette alexfauquette added performance component: charts This is the name of the generic UI component, not the React module! labels Aug 21, 2024
@mui-bot
Copy link

mui-bot commented Aug 21, 2024

Deploy preview: https://deploy-preview-14278--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 07038c4

Copy link

codspeed-hq bot commented Aug 21, 2024

CodSpeed Performance Report

Merging #14278 will improve performances by 31.49%

Comparing alexfauquette:iprove-bar-perfs (07038c4) with master (eb5644b)

Summary

⚡ 1 improvements
✅ 2 untouched benchmarks

Benchmarks breakdown

Benchmark master alexfauquette:iprove-bar-perfs Change
BarChart with big data amount 1.6 s 1.2 s +31.49%

@alexfauquette alexfauquette merged commit 15e0171 into mui:master Aug 21, 2024
23 checks passed
@alexfauquette alexfauquette deleted the iprove-bar-perfs branch August 21, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: charts This is the name of the generic UI component, not the React module! performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants