[core] Setup e2e tests #1443
Merged
[core] Setup e2e tests #1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanailH
added
core
|
is it running in the CI? |
dtassone
approved these changes
Apr 20, 2021
oliviertassinari
requested changes
Apr 20, 2021
| columns: [{ field: 'brand', width: 100 }], | ||
| }; | ||
|
|
||
| export default function BaseGridFocus() { |
There was a problem hiding this comment.
I don't think that the file structure is flying. Material-UI X while host more components. I think that a prefix with the name of the component and a flat structure after would work a lot better. So 👍 for test/e2e/fixtures/DataGrid/KeyboardNavigationFocus.tsx
There was a problem hiding this comment.
Yes, I was not convinced about the naming. I'll update it
Should I add a new section in the |
Yes, we need a new CI step |
oliviertassinari
approved these changes
Apr 20, 2021
There was a problem hiding this comment.
👍
Side notes for the future:
- We might be able to share some of the visual regression and end-to-end set up with the main repo. So improvements that @eps1lon bring in the core repo can benefit the whole codebase. But maybe it's too early
- The test assertion seems to be a weak spot.
expect(await page.evaluate(()adds quite some boilerplate. - We could have Storybook render all the content inside
test/e2e/fixtures/. These new tests are already rendered by the end-to-end infra but maybe having them inside Storybook could serve use cases as well. Not sure, it could also slow the storybook even more.
Closed
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to provide the ability to test real browser interaction based on this pr mui/material-ui#25405
I've added a simple test case to illustrate that the setup is working.