-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Remove TypeScript v3 outdated version mentions #14443
Conversation
docs/data/data-grid/style/style.md
Outdated
@@ -122,6 +122,7 @@ By default, the Data Grid uses the Material UI `theme.palette.background.defaul | |||
|
|||
```tsx | |||
import { createTheme } from '@mui/material/styles'; | |||
import type {} from "@mui/x-data-grid/themeAugmentation"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this fixes #14115, though it is already mentioned here https://mui.com/x/react-data-grid/getting-started/#typescript
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For #14115, I don't think that this PR solves it, IMHO, #14115 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will do this in a separate PR 👍
Head branch was pushed to by a user without write access
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! 🙏
hm...same picker test is failing again, it seems like #14457 missed something ? |
This branch was just out of sync with |
MateriaL UI sets the minimum supported ts version to 4.7, so it's time to remove v3 mentions in docs.
Fixes #14239