-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[data grid] Remove minFirstColumn
from GetHeadersParams
interface
#14450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zannager
added
the
component: data grid
This is the name of the generic UI component, not the React module!
label
Sep 2, 2024
@romgrk could this be merged? :) |
romgrk
approved these changes
Sep 17, 2024
Deploy preview: https://deploy-preview-14450--material-ui-x.netlify.app/ |
auto-merge was automatically disabled
September 17, 2024 04:41
Head branch was pushed to by a user without write access
k-rajat19
force-pushed
the
min-first-column
branch
from
September 17, 2024 04:41
25dc914
to
1584ee3
Compare
auto-merge was automatically disabled
September 17, 2024 06:34
Head branch was pushed to by a user without write access
k-rajat19
force-pushed
the
min-first-column
branch
from
September 17, 2024 06:34
ddf538f
to
a689a8b
Compare
failing tests fixed by #14644 |
arthurbalduini
pushed a commit
to arthurbalduini/mui-x
that referenced
this pull request
Sep 30, 2024
…mui#14450) Co-authored-by: Rom Grk <romgrk.cc@gmail.com>
oliviertassinari
changed the title
[data-grid] Remove
[data grid] Remove Oct 2, 2024
minFirstColumn
from GetHeadersParams
interfaceminFirstColumn
from GetHeadersParams
interface
This was referenced Oct 25, 2024
This was referenced Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: data grid
This is the name of the generic UI component, not the React module!
core
Infrastructure work going on behind the scenes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
usage of
minFirstColumn
was removed in this PR #10059, so it can be removed completely.