Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data grid] Remove minFirstColumn from GetHeadersParams interface #14450

Merged
merged 9 commits into from
Sep 18, 2024

Conversation

k-rajat19
Copy link
Contributor

usage of minFirstColumn was removed in this PR #10059, so it can be removed completely.

@zannager zannager added the component: data grid This is the name of the generic UI component, not the React module! label Sep 2, 2024
@k-rajat19
Copy link
Contributor Author

@romgrk could this be merged? :)

@romgrk romgrk enabled auto-merge (squash) September 17, 2024 04:21
@mui-bot
Copy link

mui-bot commented Sep 17, 2024

Deploy preview: https://deploy-preview-14450--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against f1b5e14

auto-merge was automatically disabled September 17, 2024 04:41

Head branch was pushed to by a user without write access

@romgrk romgrk enabled auto-merge (squash) September 17, 2024 04:54
auto-merge was automatically disabled September 17, 2024 06:34

Head branch was pushed to by a user without write access

@k-rajat19
Copy link
Contributor Author

k-rajat19 commented Sep 17, 2024

failing tests fixed by #14644

@k-rajat19 k-rajat19 requested a review from romgrk September 17, 2024 17:10
@romgrk romgrk enabled auto-merge (squash) September 18, 2024 07:28
@romgrk romgrk merged commit edc76e0 into mui:master Sep 18, 2024
16 checks passed
@k-rajat19 k-rajat19 deleted the min-first-column branch September 18, 2024 07:43
arthurbalduini pushed a commit to arthurbalduini/mui-x that referenced this pull request Sep 30, 2024
@oliviertassinari oliviertassinari added the core Infrastructure work going on behind the scenes label Oct 2, 2024
@oliviertassinari oliviertassinari changed the title [data-grid] Remove minFirstColumn from GetHeadersParams interface [data grid] Remove minFirstColumn from GetHeadersParams interface Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants