-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[charts] Add a PolarProvider
to manage polar axes
#14642
Conversation
Deploy preview: https://deploy-preview-14642--material-ui-x.netlify.app/ |
CodSpeed Performance ReportMerging #14642 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 👍, left a comment in code plus the observation below
There is an empty file at packages/x-charts/src/context/PolarProvider/defaultizeAxis.ts
I merged the two computeValue in one. It's not supper coherent because the function is use in cartesian and polar context, plus exported as a cartesian axis utils. But should be good enough for now. I'm not sure about how much we will use this PolarProvider outside of the radar |
I think the changes are small enough that makes sense to have a single logic. In regards to where to put it, we could move it into the |
Follow-up of #14641
It introduces a
PolarProvider
which has similar behavior has the cartesian one. The main differences:startAngle
toendAngle
minRadius
tomaxRadius
Note the provider is not exported. So this is still internal code