Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-infra] Replace or remove all instances of e identifier #14724

Merged
merged 11 commits into from
Oct 4, 2024

Conversation

samuelsycamore
Copy link
Contributor

@samuelsycamore samuelsycamore commented Sep 24, 2024

Closes #14693.

Preparing for mui/material-ui#43866

There are a few identifiers here that could be better named because I was running into the no-shadow rule and wasn't entirely sure how best to proceed, and a few that I had to add ignore comments for because they're part of an "a-b-c" variable naming convention.

@samuelsycamore samuelsycamore added the scope: code-infra Specific to the core-infra product label Sep 24, 2024
@samuelsycamore samuelsycamore requested review from Janpot, LukasTy and a team September 24, 2024 23:06
@mui-bot
Copy link

mui-bot commented Sep 24, 2024

Deploy preview: https://deploy-preview-14724--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 85fa97d

@samuelsycamore samuelsycamore marked this pull request as ready for review September 25, 2024 16:56
@samuelsycamore samuelsycamore requested review from JCQuintas and a team September 26, 2024 15:16
Co-authored-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
Signed-off-by: Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of these improvements. 👍 🙌

docs/src/modules/components/overview/Keyboard.tsx Outdated Show resolved Hide resolved
Copy link
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleaning 🙏

samuelsycamore and others added 2 commits September 30, 2024 08:46
Signed-off-by: Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Copy link

github-actions bot commented Oct 4, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: code-infra Specific to the core-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants