[DataGrid] Fix value type in filter model for number and boolean column type #14733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-rajat19
changed the title
|
Deploy preview: https://deploy-preview-14733--material-ui-x.netlify.app/ |
zannager
added
the
component: data grid
oliviertassinari
changed the title
|
@romgrk, can you please look at these changes when you have time? |
romgrk
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14327
Currently,
numberandbooleancolumn types store filter item value in filter model as astringtype (see demo)we should rather store these values according to their respective column type (we already do that for
dateanddateTimecolumn types).