[DataGrid] Add missing style overrides #16272
Conversation
KenanYusuf
added
component: data grid
|
Deploy preview: https://deploy-preview-16272--material-ui-x.netlify.app/ |
There was a problem hiding this comment.
I think I'd avoid the changes in this file, some classes really don't have a viable use-case to be style-overridden (like virtualScroller-hasScrollX).
There was a problem hiding this comment.
some classes really don't have a viable use-case to be style-overridden
It's unlikely, but I don't think there is any harm in making it possible. As a user, I would assume that styles are overridable for any MUI class.
There was a problem hiding this comment.
Is that class publicly documented? Some of them are just for internal use.
The downside is that it makes the code here more verbose.
There was a problem hiding this comment.
Discussed in team meeting today, the main points were:
- There's no such thing as a private/internal class really because they are visible when inspecting the DOM
- We could come up with a different naming convention for classes that are only intended to be used internally
We came to a consensus that all classes should be added to style overrides for consistency.
Fixes #16159
There were some missing classes in the
GridRootStylesoverrides. Some overrides were moved to the componentstyledwhere it was straightforward to do so.