Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Avoid <GridRoot /> double-render pass on mount in SPA mode (@lauri865) #16480

Merged
merged 5 commits into from
Feb 6, 2025
Merged

[DataGrid] Avoid <GridRoot /> double-render pass on mount in SPA mode (@lauri865) #16480

merged 5 commits into from
Feb 6, 2025

Conversation

cherniavskii
Copy link
Member

@cherniavskii cherniavskii commented Feb 5, 2025 •
edited
Loading

Cherry-pick of #15648

I've reverted the breaking changes to filteredRowsLookup and visibleRowsLookup (0952149).

@cherniavskii cherniavskii added performance component: data grid This is the name of the generic UI component, not the React module! cherry-pick The PR was cherry-picked from the newer alpha/beta/stable branch labels Feb 5, 2025
@mui-bot
Copy link

mui-bot commented Feb 5, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-16480--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 8f955fc

@cherniavskii cherniavskii requested a review from a team February 6, 2025 13:58
@cherniavskii cherniavskii marked this pull request as ready for review February 6, 2025 13:58
@cherniavskii
Copy link
Member Author

cherniavskii commented Feb 6, 2025 •
edited
Loading

I have no idea why this test consistently fails. Apparently, #16382 wasn't enough to fix that 🤔

UPD: The issue seems to be coming from useMockServer – the test passes once I got rid of useMockServer in cfe1750 (#16480)

@MBilalShafi
Copy link
Member

MBilalShafi commented Feb 6, 2025 •
edited
Loading

UPD: The issue seems to be coming from useMockServer – the test passes once I got rid of useMockServer in cfe1750 (#16480)

useMockServer is definitely not that optimized esp. for being used in tests. (Although we worked them around for now) To solve these issues properly, we either have to extract a synchronous (non-hook) version of useMockServer for tests or shift to another backend strategy, as mentioned in #15098.

@cherniavskii cherniavskii merged commit ebbd0ab into mui:v7.x Feb 6, 2025
16 checks passed
@cherniavskii cherniavskii deleted the gridroot-rerenders-on-mount-v7 branch February 6, 2025 18:47
@cherniavskii cherniavskii mentioned this pull request Feb 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romgrk romgrk romgrk approved these changes

Assignees
No one assigned
Labels
cherry-pick The PR was cherry-picked from the newer alpha/beta/stable branch component: data grid This is the name of the generic UI component, not the React module! performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cherniavskii @mui-bot @MBilalShafi @romgrk