[DataGridPremium] Fix Excel export Web Worker demo not working in dev mode #16517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cherniavskii
added
component: data grid
|
Deploy preview: https://deploy-preview-16517--material-ui-x.netlify.app/ Updated pages: |
cherniavskii
commented
Feb 10, 2025
There was a problem hiding this comment.
I don't think this file was ever used
cherniavskii
added
needs cherry-pick
romgrk
approved these changes
Feb 10, 2025
KenanYusuf
approved these changes
Feb 11, 2025
cherniavskii
changed the title
|
Cherry-pick PRs will be created targeting branches: v7.x |
cherniavskii
added a commit
that referenced
this pull request
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
I assume it works in production because of tree shaking, which is unavailable in dev mode.
I reorganized the code to ensure
setupExcelExportWebWorkerdoesn't pull in things it doesn't use.Also, added a subpath export:
@mui/x-data-grid-premium/setupExcelExportWebWorker. It's optional, but looks like a much better option for usage in a WebWorker.