[DataGrid] apiRef.current.getRow can return null #2010
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1995 (comment)
For
getRowParams
/getCellParams
/getBaseCellParams
I could returnnull
instead of throwing, but it would mean checking if the return value is null in a lot more places.For
getCellValue
if I returnnull
we could not differentiate a cell with the valuenull
and a cell with a non existing IDFor
selectRow
, I had to update the test because we were asking for a row that do not exist but we never checked the return value of the function in the tests. I don't know what is the best behavior here, does it make sense to returnnull
instead of crashing ?