Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Correctly test column visibility switch impact on column width #2130

Merged
merged 5 commits into from
Jul 19, 2021
Merged

[core] Correctly test column visibility switch impact on column width #2130

merged 5 commits into from
Jul 19, 2021
+60 −4

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Jul 12, 2021 •
edited
Loading

@oliviertassinari this do fail when using a commit older than #2034

@flaviendelangle flaviendelangle self-assigned this Jul 12, 2021
@flaviendelangle flaviendelangle added the core Infrastructure work going on behind the scenes label Jul 12, 2021
oliviertassinari
oliviertassinari reviewed Jul 12, 2021
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup, looks great. I guess we could have kept the other test if we have no other like this.

@flaviendelangle
Copy link
Member Author

flaviendelangle commented Jul 12, 2021 •
edited
Loading

It does indeed test something that could break
I'm adding it back

@flaviendelangle flaviendelangle merged commit bc12054 into mui:master Jul 19, 2021
@flaviendelangle flaviendelangle deleted the test-column-visibility branch July 19, 2021 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees

@flaviendelangle flaviendelangle

Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flaviendelangle @oliviertassinari