-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Isolate DataGrid and XGrid #2176
Conversation
@mui-org/x Who wants to own and continue these changes? |
I can take a look 👍 |
Agree, it's meant to be a step that allows us to build new hooks for XGrid only going forward. |
0b70579
to
d326f6d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, it seems that you keep getting conflicts with it. It might be a good one to merge sooner rather than later 😁
export const DataGrid = React.memo(DataGridRaw); | ||
|
||
// @ts-ignore | ||
DataGrid.propTypes = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't notice this change. I think that we should revert the propTypes
change. The propTypes
needs to be in the same file for https://github.com/oliviertassinari/babel-plugin-transform-react-remove-prop-types to trigger. Actually, we also need to replace the TypeScript bundler to use the Babel bundler of the core that leverages this optimization and others. Once we move the infra to v5. the prop-types will be automatically generated and in the same file.
TODO
Part of #924