Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Isolate DataGrid and XGrid #2176

Merged
merged 55 commits into from
Aug 5, 2021
Merged

Conversation

dtassone
Copy link
Member

@dtassone dtassone commented Jul 20, 2021

TODO

  • refactor how to inject 'useThemeProps' as it's breaking immunity
  • refactor selection model to accept 'GridRowId' as it's breaking immunity

Part of #924

@dtassone dtassone marked this pull request as draft July 20, 2021 16:21
@oliviertassinari
Copy link
Member

@mui-org/x Who wants to own and continue these changes?

@flaviendelangle
Copy link
Member

I can take a look 👍
But do we agree that this is a first draft that won't remove the XGrid code contained in the hooks from the DataGrid bundle ?

@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 26, 2021

do we agree that this is a first draft that won't remove the XGrid code contained in the hooks from the DataGrid bundle?

Agree, it's meant to be a step that allows us to build new hooks for XGrid only going forward.

@oliviertassinari oliviertassinari added the core Infrastructure work going on behind the scenes label Jul 26, 2021
@oliviertassinari oliviertassinari changed the title [DataGrid] Isolate DataGrid and XGrid [core] Isolate DataGrid and XGrid Jul 26, 2021
@oliviertassinari oliviertassinari added the component: data grid This is the name of the generic UI component, not the React module! label Jul 26, 2021
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, it seems that you keep getting conflicts with it. It might be a good one to merge sooner rather than later 😁

export const DataGrid = React.memo(DataGridRaw);

// @ts-ignore
DataGrid.propTypes = {
Copy link
Member

@oliviertassinari oliviertassinari Aug 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't notice this change. I think that we should revert the propTypes change. The propTypes needs to be in the same file for https://github.com/oliviertassinari/babel-plugin-transform-react-remove-prop-types to trigger. Actually, we also need to replace the TypeScript bundler to use the Babel bundler of the core that leverages this optimization and others. Once we move the infra to v5. the prop-types will be automatically generated and in the same file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants