[core] Don't export internal utils

[flaviendelangle]

Part of #2227

The following variables and types are not exported anymore from @material-ui/data-grid and @material-ui/x-grid

// utils.domUtils.ts

- findParentElementFromClassName
- getRowEl
- isGridCellRoot
- isGridHeaderCellRoot
- getIdFromRowElem
- getFieldFromHeaderElem
- findHeaderElementFromField
- findGridCellElementsFromCol
- escapeOperandAttributeSelector
- getGridColumnHeaderElement
- getGridRowElement
- getGridCellElement
- isOverflown

// utils/exportAs.ts
- exportAs

// utils/getGridLocalization
- LocalizationV4
- LocalizationV5
- Localization
- getGridLocalization

// utils/keyboardUtils.ts
- isHomeOrEndKeys
- isPageKeys
- isDeleteKeys
- printableCharRegex
- isPrintableKey
- GRID_MULTIPLE_SELECTION_KEYS
- GRID_CELL_EXIT_EDIT_MODE_KEYS
- GRID_CELL_EDIT_COMMIT_KEYS
- isMultipleKey
- isCellEnterEditModeKeys
- isCellExitEditModeKeys
- isCellEditCommitKeys
- isNavigationKey
- isKeyboardEvent
- isHideMenuKey

// utils/material-ui-utils.ts
- DistributiveOmit
- InternalStandardProps
- useEventCallback
- useEnhancedEffect
- useThemeProps
- composeClasses
- generateUtilityClass
- generateUtilityClasses

// utils/mergeUtils.ts
- mergeGridColTypes
- removeUndefinedProps
- mergeGridOptions

// utils/sortingUtils.ts
- nextGridSortDirection
- isDesc
- gridNillComparer
- gridStringNumberComparer
- gridNumberComparer
- gridDateComparer

// utils/utils.ts
- isDeepEqual
- isNumber
- isFunction
- isObject
- getMuiVersion
- muiStyleAlpha
- createTheme
- localStorageAvailable
- Optional
- getDataGridUtilityClass
- escapeRegExp
- getThemePaletteMode

These three utils are used in the demo.
Do we want to export them or let the user re-implement them ?

- getThemePaletteMode
- escapeRegExp
- isOverflown

For escapeRegExp and isOverflown, I don't think it's the role of MUI to provide such generic methods.
For getThemePaletteMode, the core could export it but if it does not I suppose we shouldn't do it

[oliviertassinari]

Interesting, we can't use @material-ui/data-grid/utils/utils because of the _modules_ folder structure. This folder structure prevents us to split MIT and Commercially licensed code. So we need to move most of the modules away. Once we do how do XGrid and DataGrid share the utils? I guess we have to either keep the utils in or export them as unstable_. Anyway, it's a problem for our future self. Making the utils private is the right thing to do.

[flaviendelangle]

Yes, removing the unnecessary exports is a first step to help us reorganize the codebase between the MIT and the Commercially licensed code.

And there is some code that is not Grid related and should not be exported and not be in a grid folder but probably in a _shared_ directory that will be accessed by the grids but also the new X components.
That's the case for a lot of the utils.

[oliviertassinari]

but probably in a shared directory that will be accessed by the grids but also the new X components.

If it needs to be access cross components, then we need a similar package to @material-ui/utils. Maybe we should name them:

• @mui/core-utils (prev @material-ui/utils)
• @mui/x-utils

Related to https://www.notion.so/mui-org/Rearranging-the-packages-2f700caf8b5e48559fe86ebb648ed91a

[oliviertassinari]

Do we want to export them or let the user re-implement them ?

+1 for re-implementation

[ru4ert]

OK, copied that there have been changes applied.

pre Update
there was this way to access the object shapes.

import { createTheme, DataGrid, GridCellParams, GridColDef, GridEditCellPropsParams, GridRowModel, GridRowSelectedParams, GridSelectionModelChangeParams, GRID_CELL_EDIT_PROPS_CHANGE } from '@material-ui/data-grid'
[...]

const renderEditCell = (params: GridCellParams) => {
    return <EditTypeOfProduct {...params} Companys={values.Companys} />
}

After the update

Module '"@material-ui/data-grid"' has no exported member 'createTheme'.
Module '"@material-ui/data-grid"' has no exported member 'GridRowSelectedParams'.
Module '"@material-ui/data-grid"' has no exported member 'GridSelectionModelChangeParams'.

Is there a new alternative way?

[oliviertassinari]

@Rupert-com

• createTheme import from the core package:

import { createTheme } from '@material-ui/core/styles';

• GridRowSelectedParams see [DataGrid] Implement useControlState hook, and add control state on selectionModel #1823
• GridSelectionModelChangeParams see [DataGrid] Implement useControlState hook, and add control state on selectionModel #1823