-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Avoid useless columns preprocessing on Grid mount #2286
Conversation
It seems to fix #1562, proof https://codesandbox.io/s/datagrid-legacy-vs-concurrent-root-forked-4x35b?file=/demo.js |
I was not the main goal but nice 😄 |
@oliviertassinari if #2344 has the same behavior, it is indeed simpler and I'm OK to close this one |
@flaviendelangle I'm not exactly sure it has the same behavior. I looked at it because I was suspicious we could have a simpler logic/wanted to understand what was going on in this hook. I don't plan to push #2344 much further. If you can continue the exploration, and pick whoever works best, I think that it would be great. |
After a few checks, the behavior seems to be very similar |
Alright, at least, it easy to follow. Note that we have a few tests in the codebase that assert we don't render too many times. We could consider doing the same if we see regressions. |
Avoid double
useEffect
run during grid initFixes #1562