[core] New internal hook: useGridRowGroupsPreProcessing #2840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
component: data grid
flaviendelangle
requested review from
m4theushw,
DanailH and
alexfauquette
and removed request for
m4theushw
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
DanailH
reviewed
Oct 13, 2021
packages/grid/_modules_/grid/hooks/core/rowGroupsPerProcessing/gridRowGroupsPreProcessingApi.ts
Outdated
Show resolved
Hide resolved
DanailH
reviewed
Oct 13, 2021
packages/grid/_modules_/grid/hooks/core/rowGroupsPerProcessing/useGridRowGroupsPreProcessing.ts
Outdated
Show resolved
Hide resolved
DanailH
reviewed
Oct 13, 2021
packages/grid/_modules_/grid/hooks/core/rowGroupsPerProcessing/useGridRowGroupsPreProcessing.ts
Show resolved
Hide resolved
DanailH
reviewed
Oct 13, 2021
DanailH
approved these changes
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #2725
Part of #2813
The grouping process is not used for now, both #2725 and #212 will register a grouping algorithm using this new method.
useGridRowsshould use them in a later extracted PR from #2725, it needs to also migrate the Filter and Sorting to the new tree structure.