Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Add yarn workspaces #33

Merged
merged 1 commit into from
Jun 25, 2020
Merged

[core] Add yarn workspaces #33

merged 1 commit into from
Jun 25, 2020

Conversation

dtassone
Copy link
Member

@dtassone dtassone commented Jun 22, 2020 •
edited by oliviertassinari
Loading

Closes #31

@oliviertassinari oliviertassinari changed the title added yarn workspaces add yarn workspaces Jun 22, 2020
@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 22, 2020 •
edited
Loading

Does it mean we can remove all the package-lock.json? :D

@dtassone
Copy link
Member Author

Does it mean we can remove all the package-lock.json? :D

Yes it's coming :)

oliviertassinari
oliviertassinari requested changes Jun 23, 2020
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we can add package-lock.json in the .gitignore file after the changes, it will help avoid mistakes.

@oliviertassinari oliviertassinari changed the title add yarn workspaces [core] Add yarn workspaces Jun 23, 2020
@dtassone
Copy link
Member Author

I will update this one when I finish my current changes

@dtassone dtassone merged commit 7759f11 into master Jun 25, 2020
@dtassone dtassone deleted the yarnW branch June 25, 2020 16:29
@oliviertassinari oliviertassinari mentioned this pull request Jul 1, 2020
Closed
12 tasks
@oliviertassinari oliviertassinari added the core Infrastructure work going on behind the scenes label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari requested changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtassone @oliviertassinari