[DataGridPro] Do not expand row children when pressing Shift
+ Space
#3380
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #3277
Shift
+Space
is selecting / unselecting the row, the children selection should only be applied when pressingSpace
withoutShift
I also added two small core improvements
groupingColDef
computation in auseCallback
instead of auseMemo
to avoid running theprop.groupingColDef
callback version on the tree data grouping column when the tree data is not enabled.rowNode
from the params in thecellKeyDown
event instead of using theapiRef
(helps us remove an useless check)