Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Close other actions menus when opening a new one #3492

Merged
merged 2 commits into from
Dec 23, 2021

Conversation

m4theushw
Copy link
Member

@m4theushw m4theushw commented Dec 22, 2021

Fixes #3489

Preview: https://deploy-preview-3492--material-ui-x.netlify.app/components/data-grid/columns/#special-properties

If we continue to add more column types with interactive elements, then it makes sense to add a per-column disableSelectionOnClick.

@m4theushw m4theushw self-assigned this Dec 22, 2021
@m4theushw m4theushw added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! labels Dec 22, 2021
@flaviendelangle
Copy link
Member

If we continue to add more column types with interactive elements, then it makes sense to add a per-column disableSelectionOnClick.

I agree that putting logic for a specific type in useGridSelection is not great in the longer run.
But good enough for a 1st version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DataGrid] Previous "menuList" hang on screen every click for "type:actions" cells
2 participants