[core] Migrate `@mui/x-license-pro` to the new bundling strategy #3738

flaviendelangle · 2022-01-25T14:32:11Z

Part of #18
Part of #3608

What's next ?

Migrate @mui/x-data-grid-generator
Migrate @mui/x-data-grid-pro after [DataGridPro] Make @mui/x-data-grid-pro import shared code from @mui/x-data-grid #3688
Migrate @mui/x-data-grid after the total removal of _modules_

mui-bot · 2022-01-25T14:37:36Z

These are the results for the performance tests:

Test case	Unit	Min	Max	Median	Mean	σ
Filter 100k rows	ms	225.8	468.6	391	364.84	80.299
Sort 100k rows	ms	399.2	820	725.1	685.8	147.533
Select 100k rows	ms	183.3	268.6	210.8	216.48	28.152
Deselect 100k rows	ms	106.7	300.8	178.3	192.7	67.412

Generated by 🚫 dangerJS against bacb7d8

github-actions · 2022-01-25T16:13:27Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

flaviendelangle · 2022-02-01T10:36:39Z

packages/grid/rollup.x-data-grid-pro.config.js

        plugins: [
          [
            'transform-react-remove-prop-types',
            {
              ignoreFilenames: ['DataGridPro.tsx'],
            },
          ],
+          [
+            'search-and-replace',


I moved this replace to babel because once we remove rollup for @mui/x-data-grid-pro we won't be able to use to current plugin.

flaviendelangle · 2022-02-01T10:38:46Z

packages/x-license-pro/package.json

-    "directory": "packages/x-license-pro"
-  },
+  "types": "build/index.d.ts",
+  "license": "SEE LICENSE IN LICENSE.txt",


We now need a valid license field for bundling

flaviendelangle · 2022-02-03T10:55:17Z

package.json

@@ -57,7 +57,8 @@
    "build:codesandbox": "yarn release:build",
    "release:changelog": "node scripts/releaseChangelog",
    "release:version": "lerna version --exact --no-changelog --no-push --no-git-tag-version",
-    "release:build": "cd packages/x-license-pro && yarn build && cd ../grid/x-data-grid-pro && yarn build && cd ../x-data-grid && yarn build && cd ../x-data-grid-generator && yarn build",
+    "release:build": "yarn release:build:next && cd packages/grid/x-data-grid-pro && yarn build && cd ../x-data-grid && yarn build && cd ../x-data-grid-generator && yarn build",
+    "release:build:next": "lerna run --parallel --scope \"@mui/x-license-pro\" build",


I'm following mui/material-ui#30201, mui/material-ui#30200 because we will probably have the same issue.
But for now it's not a problem since I build the only package with the core bundling strategy before the others.

flaviendelangle · 2022-02-03T12:15:35Z

packages/x-license-pro/src/licenseStatus.ts

  NotFound = 'NotFound',
  Invalid = 'Invalid',
  Expired = 'Expired',
  Valid = 'Valid',
 }
+
+export { LicenseStatus };


I have a weird compilation error on Codesandbox otherwise when using our ESM bundle as the input.
It gets the following output:

exports.LicenseStatus = void 0; Object.defineProperty(exports, "__esModule", { value: true }); let LicenseStatus; exports.LicenseStatus = LicenseStatus; (function (LicenseStatus) { LicenseStatus["NotFound"] = "NotFound"; LicenseStatus["Invalid"] = "Invalid"; LicenseStatus["Expired"] = "Expired"; LicenseStatus["Valid"] = "Valid"; })(LicenseStatus || (LicenseStatus = {}));

And exports.LicenseStatus remains undefined (you can test in the console).

The changes in the code allow to init the enum before exporting it, which solves the problem.

@michaldudak I think you've experienced similar issue with Codesandbox recently. What was your solution to that?

Replace

export enum MyEnum { ... }

With

enum MyEnum {...} export { MyEnum }

That way you have something like

exports.LicenseStatus = void 0; Object.defineProperty(exports, "__esModule", { value: true }); let LicenseStatus; -exports.LicenseStatus = LicenseStatus; (function (LicenseStatus) { LicenseStatus["NotFound"] = "NotFound"; LicenseStatus["Invalid"] = "Invalid"; LicenseStatus["Expired"] = "Expired"; LicenseStatus["Valid"] = "Valid"; })(LicenseStatus || (LicenseStatus = {})); +exports.LicenseStatus = LicenseStatus;

It looks like an error in the Codesandbox' bundler. I created an issue in their repo: codesandbox/codesandbox-client#6435

@flaviendelangle nice work finding a workaround!

Always a pleasure to dive into compiled code with 5mn between each test due to the build duration 😆

flaviendelangle · 2022-02-03T12:17:30Z

babel.config.js

@@ -1,24 +1,5 @@
 const path = require('path');


I synced this file with the core one, minus some things (we don't have there error management for instance).
I will do some tests for the packages still on the old bundling. But I would advise against releasing a state where some package use the core bundling strategy and others don't.

github-actions · 2022-02-06T15:30:24Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

siriwatknp · 2022-02-08T12:24:37Z

👋 The migration PR has been merged.

Please follow these steps to make sure that the contents are all updated. (Sorry for the inconvenience)

pull latest master from upstream to your branch
if your PR has changes on the *.md or demo files, you are likely to encounter conflict because all of them have been moved to the new folder.
2.1 revert the change on those markdown files you did
2.2 pull latest master from upstream (you should not see conflict)
2.3 make the changes again at docs/data/data-grid/*
run yarn docs:api
- you might see the changes in docs/pages/x/api/data-grid/* if your PR touches some of the components
- it is okay if there is no changes

If you are struggle with the steps above, feel free to tag @siriwatknp

m4theushw

I don't have too much to say here but everything seems to still work as expected. We will need to pay more attention when migrating @mui/x-data-grid.

flaviendelangle added 5 commits January 24, 2022 10:52

[core] Prepare infra for pickers migration

0d0fabd

Work

7789edf

Merge

a6ffec7

Merge branch 'master' into infra-pickers

ee608a3

[core] Migrate @mui/x-license-pro to the new bundling strategy

f92743f

flaviendelangle added on hold There is a blocker, we need to wait core Infrastructure work going on behind the scenes labels Jan 25, 2022

flaviendelangle self-assigned this Jan 25, 2022

flaviendelangle changed the title ~~[core] Migrate @mui/x-license-pro to the new bundling strategy~~ [core] Migrate @mui/x-license-pro to the new bundling strategy Jan 25, 2022

Work

a68383b

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 25, 2022

flaviendelangle added 2 commits February 1, 2022 11:01

Merge

d5eaabc

Work

b99abfc

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 1, 2022

flaviendelangle added 3 commits February 1, 2022 11:35

Fix

262c77b

Fix

0e38aa4

Fix

3be34b8

flaviendelangle commented Feb 1, 2022

View reviewed changes

flaviendelangle added 4 commits February 1, 2022 11:42

Fix

6bc170b

Empty

74eb662

Merge branch 'master' into x-license-pro-bundling

7ea7b7a

work

d4b33b4

flaviendelangle commented Feb 3, 2022

View reviewed changes

flaviendelangle added 5 commits February 3, 2022 11:56

Work

a21c484

Work

0ad6c9f

Work

be7c0da

Work

dd5e2ef

Work

6c96aff

flaviendelangle added 4 commits February 3, 2022 13:01

Work

c90ad6a

Work

6b8abbb

Work

2b4a0e0

Work

f43fe3c

flaviendelangle commented Feb 3, 2022

View reviewed changes

flaviendelangle added 6 commits February 3, 2022 15:58

Fix

fa69aee

Work

a204b9c

Work

e08a964

Work

a6a2a70

Work

d8c5d6c

Work

839aa59

flaviendelangle marked this pull request as ready for review February 3, 2022 16:03

flaviendelangle requested review from m4theushw, oliviertassinari and cherniavskii February 3, 2022 16:03

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 6, 2022

Work

a054c1b

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 7, 2022

flaviendelangle added 3 commits February 8, 2022 14:36

Merge branch 'master' into x-license-pro-bundling

eeeeedc

Merge branch 'master' into x-license-pro-bundling

c7417c0

Fix

bacb7d8

m4theushw approved these changes Feb 12, 2022

View reviewed changes

flaviendelangle merged commit 646cdf2 into mui:master Feb 14, 2022

flaviendelangle deleted the x-license-pro-bundling branch February 14, 2022 07:38

This was referenced Feb 14, 2022

[DataGridPro] Make @mui/x-data-grid-pro import shared code from @mui/x-data-grid #3688

Merged

[DataGrid] Bundle size is way too large #18

Closed

flaviendelangle mentioned this pull request Mar 9, 2022

[DataGrid] New editing API #3963

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[core] Migrate `@mui/x-license-pro` to the new bundling strategy #3738

[core] Migrate `@mui/x-license-pro` to the new bundling strategy #3738

flaviendelangle commented Jan 25, 2022 •

edited

Loading

mui-bot commented Jan 25, 2022 •

edited

Loading

github-actions bot commented Jan 25, 2022

flaviendelangle Feb 1, 2022

flaviendelangle Feb 1, 2022

flaviendelangle Feb 3, 2022

flaviendelangle Feb 3, 2022

cherniavskii Feb 7, 2022

flaviendelangle Feb 7, 2022 •

edited

Loading

michaldudak Feb 7, 2022

flaviendelangle Feb 7, 2022

flaviendelangle Feb 3, 2022

github-actions bot commented Feb 6, 2022

siriwatknp commented Feb 8, 2022 •

edited

Loading

m4theushw left a comment

[core] Migrate @mui/x-license-pro to the new bundling strategy #3738

[core] Migrate @mui/x-license-pro to the new bundling strategy #3738

Conversation

flaviendelangle commented Jan 25, 2022 • edited Loading

What's next ?

mui-bot commented Jan 25, 2022 • edited Loading

github-actions bot commented Jan 25, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

flaviendelangle Feb 7, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Feb 6, 2022

siriwatknp commented Feb 8, 2022 • edited Loading

m4theushw left a comment

Choose a reason for hiding this comment

[core] Migrate `@mui/x-license-pro` to the new bundling strategy #3738

[core] Migrate `@mui/x-license-pro` to the new bundling strategy #3738

flaviendelangle commented Jan 25, 2022 •

edited

Loading

mui-bot commented Jan 25, 2022 •

edited

Loading

flaviendelangle Feb 7, 2022 •

edited

Loading

siriwatknp commented Feb 8, 2022 •

edited

Loading