Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Unify multi-filtering introduction with the multi-sorting introduction #3766

Merged

Conversation

flaviendelangle
Copy link
Member

No description provided.

@flaviendelangle flaviendelangle added the docs Improvements or additions to the documentation label Jan 28, 2022
@flaviendelangle flaviendelangle self-assigned this Jan 28, 2022
@mui-bot
Copy link

mui-bot commented Jan 28, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 223.9 396.1 283.7 288.7 64.028
Sort 100k rows ms 418.4 801.1 721.3 659.64 144.048
Select 100k rows ms 153.6 253.8 187.5 198.14 33.496
Deselect 100k rows ms 114.7 214.5 140.6 160.92 39.332

Generated by 🚫 dangerJS against f040566

@oliviertassinari oliviertassinari added component: data grid This is the name of the generic UI component, not the React module! feature: Filtering Related to the data grid Filtering feature feature: Sorting Related to the data grid Sorting feature and removed feature: Filtering Related to the data grid Filtering feature feature: Sorting Related to the data grid Sorting feature labels Jan 29, 2022
Copy link
Member

@m4theushw m4theushw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look vague this "Single and multi-filtering" section? It only contains a warning. Maybe we kill it and move the message to below the first demo in the page. I understand we want to say that there're two types of filtering, but we already used the single filtering for the first demo.

image

@flaviendelangle
Copy link
Member Author

flaviendelangle commented Feb 1, 2022

@m4theushw that's pretty much what I've done before this PR
But for the sorting, @joserodolfofreitas prefers to have a direct anchor to the "multi sorting" and for me both pages should be identical on that regard.

@joserodolfofreitas
Copy link
Member

Doesn't look vague this "Single and multi-filtering" section? It only contains a warning. Maybe we kill it and move the message to below the first demo in the page. I understand we want to say that there're two types of filtering, but we already used the single filtering for the first demo.

image

We're changing it to add the blue cube to the pro feature, and I think the warning box, although arguably redundant, highlights a big difference on the community vs pro in a very clear way, so I thought that we should leave it.

@joserodolfofreitas joserodolfofreitas added the feature: Filtering Related to the data grid Filtering feature label Feb 8, 2022
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 8, 2022
@github-actions
Copy link

github-actions bot commented Feb 8, 2022

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@siriwatknp
Copy link
Member

siriwatknp commented Feb 8, 2022

👋 The migration PR has been merged.

Please follow these steps to make sure that the contents are all updated. (Sorry for the inconvenience)

  1. pull latest master from upstream to your branch
  2. if your PR has changes on the *.md or demo files, you are likely to encounter conflict because all of them have been moved to the new folder.
    2.1 revert the change on those markdown files you did
    2.2 pull latest master from upstream (you should not see conflict)
    2.3 make the changes again at docs/data/data-grid/*
  3. run yarn docs:api
    • you might see the changes in docs/pages/x/api/data-grid/* if your PR touches some of the components
    • it is okay if there is no changes

If you are struggle with the steps above, feel free to tag @siriwatknp

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 8, 2022
@flaviendelangle flaviendelangle merged commit c350167 into mui:master Feb 8, 2022
@flaviendelangle flaviendelangle deleted the filter-docs-unify-sorting branch February 8, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation feature: Filtering Related to the data grid Filtering feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants