-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGridPro] Fix the height of the printed container #3879
Conversation
These are the results for the performance tests:
|
👋 The migration PR has been merged. Please follow these steps to make sure that the contents are all updated. (Sorry for the inconvenience)
If you are struggle with the steps above, feel free to tag @siriwatknp |
@alexfauquette I struggle to reproduce your issue |
Yes, the bug is still here. I made the same codesandbox from your PR: For the bug to occur, you need to open some rows. The more you open, the easiest it is to observe. In the recording, the last row is "Alta Howard (26)". First with open rows it does not appears in the print. If I close them, It appears |
@alexfauquette weird, if I open one row or even two rows, I still have the last row visible on the print EDIT: I tried openeing 4 rows and got half of the last row cut. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
@flaviendelangle that one has been sitting in draft since February. Can we close it? |
@DanailH at some point I proposed you to have a look but I think we both forgot 😆 |
@flaviendelangle thanks for the reminder. That does sound logical. |
Fixes #3820
Preview