Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Add hook useGridPagination to call onGridPage and onGridPageSize #3880

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

flaviendelangle
Copy link
Member

That way the split between useGridPage and useGridPageSize only occurs inside hooks/features/pagination
And outside of this folder we have 1 substate = 1 feature hook

@flaviendelangle flaviendelangle added core Infrastructure work going on behind the scenes component: data grid This is the name of the generic UI component, not the React module! feature: Pagination Related to the data grid Pagination feature labels Feb 7, 2022
@flaviendelangle flaviendelangle self-assigned this Feb 7, 2022
@mui-bot
Copy link

mui-bot commented Feb 7, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 235.4 558.1 371 383.56 123.549
Sort 100k rows ms 438.1 1,002.6 817.9 815.66 198.258
Select 100k rows ms 177.5 270.2 217.4 217.02 30.419
Deselect 100k rows ms 99.2 227.3 224.7 178.52 48.755

Generated by 🚫 dangerJS against e4f8672

@siriwatknp
Copy link
Member

siriwatknp commented Feb 8, 2022

👋 The migration PR has been merged.

Please follow these steps to make sure that the contents are all updated. (Sorry for the inconvenience)

  1. pull latest master from upstream to your branch
  2. if your PR has changes on the *.md or demo files, you are likely to encounter conflict because all of them have been moved to the new folder.
    2.1 revert the change on those markdown files you did
    2.2 pull latest master from upstream (you should not see conflict)
    2.3 make the changes again at docs/data/data-grid/*
  3. run yarn docs:api
    • you might see the changes in docs/pages/x/api/data-grid/* if your PR touches some of the components
    • it is okay if there is no changes

If you are struggle with the steps above, feel free to tag @siriwatknp

@flaviendelangle flaviendelangle merged commit 2bc8e32 into mui:master Feb 8, 2022
@flaviendelangle flaviendelangle deleted the useGridPagination branch February 8, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! core Infrastructure work going on behind the scenes feature: Pagination Related to the data grid Pagination feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants