Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Remove dead code #4283

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Mar 26, 2022

I have found this by looking into #4280 in more detail. This code path is never reached, it seemed to have been here for when we implemented the virtualization without using a native scroll container, so we had to reset the scrollLeft and scrollRight. This is no longer the case.

@oliviertassinari oliviertassinari added core Infrastructure work going on behind the scenes component: data grid This is the name of the generic UI component, not the React module! labels Mar 26, 2022
@mui-bot
Copy link

mui-bot commented Mar 26, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 231.2 432.7 332.1 330.42 85.358
Sort 100k rows ms 434.6 906.7 698.5 701.86 179.822
Select 100k rows ms 114.9 294.9 143.1 175.7 63.739
Deselect 100k rows ms 93.4 270.9 209.7 187.2 57.28

Generated by 🚫 dangerJS against c559916

Copy link
Member

@m4theushw m4theushw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's legacy. We can also remove the following ref now:

apiRef.current.renderingZoneRef = renderingZoneRef; // TODO remove, nobody should have access to internal parts of the virtualization

@oliviertassinari
Copy link
Member Author

We can also remove the following ref now:

Likely! I will resist the urge to spend more time on the code side by merging 😁

@oliviertassinari oliviertassinari merged commit 37f7e87 into mui:master Mar 28, 2022
@oliviertassinari oliviertassinari deleted the remove-dead-code branch March 28, 2022 18:13
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants