Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix some links to date picker docs #4362

Merged
merged 3 commits into from
Apr 5, 2022

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Apr 4, 2022

The /components/ folder looked wrong, this seems to be a safe change.


Two thoughts:

  1. The data grid entry point has a flat folder structure: https://master--material-ui-x.netlify.app/x/react-data-grid/ but the date picker doesn't: https://master--material-ui-x.netlify.app/x/react-date-pickers/getting-started/. The former seems more efficient from an SEO perspective. What if we added an overview page too for the date picker?
  2. Where should the npm @mui/x-date-picker package "homepage" link to? /x/react-date-pickers/ or the specific component. I kind of like the former for suggesting it's a broad package, date picker, time picker, etc.

@mui-bot
Copy link

mui-bot commented Apr 4, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 247.7 466.9 408 362.5 84.565
Sort 100k rows ms 535.7 935.6 774.6 725.1 149.259
Select 100k rows ms 127.3 278.4 181.7 181.86 54.041
Deselect 100k rows ms 109.9 196 180 159.1 37.204

Generated by 🚫 dangerJS against 686608c

@oliviertassinari oliviertassinari force-pushed the oliviertassinari-patch-1 branch from a00f5a2 to 686608c Compare April 4, 2022 22:10
@flaviendelangle
Copy link
Member

@oliviertassinari

I did not create a pickers home page for now. The closest we have is the Getting Started page.
But we should probably create one in the future yes.

@@ -38,7 +38,7 @@ type StaticDateTimePickerComponent = (<TDate>(
*
* Demos:
*
* - [Date Time Picker](https://mui.com/components/x/react-date-pickers/date-time-picker/)
* - [Date Time Picker](https://mui.com/x/react-date-pickers/date-time-picker/)
Copy link
Member Author

@oliviertassinari oliviertassinari Apr 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In MUI Core, I believe these comments are generated automatically and kept in sync in each PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will probably have improvements to do for this part indeed

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Apr 5, 2022
@oliviertassinari oliviertassinari changed the title [docs] Fix homepage date picker [docs] Fix some links to date picker docs Apr 5, 2022
@oliviertassinari oliviertassinari merged commit 1f9ee01 into master Apr 5, 2022
@oliviertassinari oliviertassinari deleted the oliviertassinari-patch-1 branch April 5, 2022 10:48
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants