Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Clarify where to install the license #4452

Merged
merged 8 commits into from
Apr 21, 2022

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Apr 11, 2022

This PR is trying to better answer https://mui.zendesk.com/agent/tickets/2851.

I'm also doing a few small polishes after #4298

  1. Move License key installation from a h3 to a h2. I don't think that it should be under the legal license section. The license key is a different notion, something to help developers remember about the legal license. I feel that having it at the same level as the license section would make it clear.
  2. Mention a bit how Premium is not available yet.
  3. Start the license section to explain why it exists
  4. Update the README to link more of the docs, less work to keep one place up to date than one.
  5. Cover https://mui.zendesk.com/agent/tickets/2946 too. It's the same question as in https://stackoverflow.com/questions/70838326/where-should-the-mui-x-pro-license-key-be-installed/70901041#70901041

https://deploy-preview-4452--material-ui-x.netlify.app/x/advanced-components/

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Apr 11, 2022
@mui-bot
Copy link

mui-bot commented Apr 11, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 361 530.7 423.3 426.42 62.164
Sort 100k rows ms 497.3 1,040.4 497.3 811.04 209.471
Select 100k rows ms 177.1 291 197 214 39.775
Deselect 100k rows ms 119.9 199.7 167.1 163.38 33.007

Generated by 🚫 dangerJS against 126d591

Copy link
Member

@joserodolfofreitas joserodolfofreitas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@oliviertassinari oliviertassinari merged commit 821ece4 into mui:master Apr 21, 2022
@oliviertassinari oliviertassinari deleted the improve-docs-license branch April 21, 2022 15:53
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants