-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v5.9.0 #4491
v5.9.0 #4491
Conversation
|
||
### Core | ||
|
||
- [core] Add technical doc for pipe processing and family processing (#4322) @flaviendelangle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is currently not very clear which packages are impacted by these core changes.
Sometime it is a change cross package (for the doc gen for instance)
But sometimes it is a change inside one of the package.
Should we prefix by the component family here instead of "Core" now that we have several ?
For instance
- [infra] Don't upgrade CircleCI node ([core] Don't upgrade CircleCI node #4457) @m4theushw
- [infra] Fix flaky e2e-website tests in CI ([test] Fix flaky e2e-website tests in CI #4136) @cherniavskii
- ....
- [pickers] Fix typos and JSDoc ([core] Fix typos and JSDoc #4406) @flaviendelangle
- [data grid] Move away for the event system to trigger pipe processings ([core] Move away for the event system to trigger pipe processings #4378) @flaviendelangle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we keep [core]
prefix and use label to differentiate between data grid and pickers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not see a big interest in replacing [core]
because developers do not really need to read those lines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is mostly for us, as the team grow I think it should be clear looking at a PR if it impacts the pickers or the datagrid, or the charts, etc...
But the label could work.
That would mean put the "data grid" label on the "[core]" PR that modifies code on the grid packages (same for pickers).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would mean put the "data grid" label on the "[core]" PR that modifies code on the grid packages (same for pickers).
Makes total sense to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The core repo seems to use [core]
only for changes in the infra. I think we used [core]
in the past because there was a lot of changes in internal parts. Maybe now, with two components, makes sense to use the prefix of the component affected. The "Add technical doc for pipe processing and family processing" item I would keep with [core]
because I understand that [docs]
is only for changes that affect the deployed docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that [docs] is only for changes that affect the deployed docs.
Agree
As for moving everything not infra inside the package sections, I don't have a strong preference
These are the results for the performance tests:
|
|
||
### Core | ||
|
||
- [core] Add technical doc for pipe processing and family processing (#4322) @flaviendelangle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not see a big interest in replacing [core]
because developers do not really need to read those lines.
Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
Co-authored-by: Matheus Wichman <matheushw@outlook.com>
Co-authored-by: Matheus Wichman <matheushw@outlook.com>
Co-authored-by: Matheus Wichman <matheushw@outlook.com>
Co-authored-by: Matheus Wichman <matheushw@outlook.com>
Co-authored-by: Matheus Wichman <matheushw@outlook.com>
Co-authored-by: Matheus Wichman <matheushw@outlook.com>
Compare the last tag with the branch upon which you want to release (
next
for the alpha / beta releases andmaster
for the current stable version).To do so, use
yarn release:changelog
The options are the following:yarn release:changelog --githubToken YOUR_GITHUB_TOKEN (needs "public_repo" permission) --lastRelease The release to compare against (default: the last one) --release The branch to release (default: master)
You can also provide the github token by setting
process.env.GITHUB_TOKEN
variable.In case of a problem, another method to generate the changelog is available at the end of this page.
Clean the generated changelog, to match the format of https://github.com/mui/mui-x/releases.
Update the root
package.json
's versionUpdate the versions of the other
package.json
files and of the dependencies withyarn release:version
.Fix manually the package version in
x-date-picker/package.json
andx-date-picker-pro/package.json
.Open PR with changes and wait for review and green CI.
Merge PR once CI is green, and it has been approved.
Release the packages
yarn
.yarn release:build
.yarn release:publish
(you need your 2FA device).git tag -a v4.0.0-alpha.30 -m "Version 4.0.0-alpha.30" && git push upstream --tag
Publish the documentation
The documentation must be updated on the
docs-vX
branch (docs-v4
forv4.X
releases,docs-v5
forv5.X
releases, ...)You can follow the deployment process on the Netlify Dashboard
Once deployed, it will be accessible at https://material-ui-x.netlify.app/ for the
docs-v5
deployment.Publish GitHub release
Announce