Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.9.0 #4491

Merged
merged 23 commits into from
Apr 14, 2022
Merged

v5.9.0 #4491

merged 23 commits into from
Apr 14, 2022

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Apr 13, 2022

  • Compare the last tag with the branch upon which you want to release (next for the alpha / beta releases and master for the current stable version).
    To do so, use yarn release:changelog The options are the following:

    yarn release:changelog
       --githubToken   YOUR_GITHUB_TOKEN (needs "public_repo" permission)
       --lastRelease   The release to compare against (default: the last one)
       --release       The branch to release (default: master)

    You can also provide the github token by setting process.env.GITHUB_TOKEN variable.

    In case of a problem, another method to generate the changelog is available at the end of this page.

  • Clean the generated changelog, to match the format of https://github.com/mui/mui-x/releases.

  • Update the root package.json's version

  • Update the versions of the other package.json files and of the dependencies with yarn release:version.

  • Fix manually the package version in x-date-picker/package.json and x-date-picker-pro/package.json.

  • Open PR with changes and wait for review and green CI.

  • Merge PR once CI is green, and it has been approved.

Release the packages

  • Checkout the last version of the working branch
  • Make sure you have the latest dependencies installed: yarn.
  • Build the packages: yarn release:build.
  • Release the versions on npm: yarn release:publish (you need your 2FA device).
  • Create a new tag named with the release you just did git tag -a v4.0.0-alpha.30 -m "Version 4.0.0-alpha.30" && git push upstream --tag

Publish the documentation

The documentation must be updated on the docs-vX branch (docs-v4 for v4.X releases, docs-v5 for v5.X releases, ...)

  • Push the working branch on the documentation release branch to deploy the documentation with the latest changes.
git push upstream master:docs-v5 -f

You can follow the deployment process on the Netlify Dashboard
Once deployed, it will be accessible at https://material-ui-x.netlify.app/ for the docs-v5 deployment.

Publish GitHub release

Announce


### Core

- [core] Add technical doc for pipe processing and family processing (#4322) @flaviendelangle
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is currently not very clear which packages are impacted by these core changes.
Sometime it is a change cross package (for the doc gen for instance)
But sometimes it is a change inside one of the package.

Should we prefix by the component family here instead of "Core" now that we have several ?
For instance

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep [core] prefix and use label to differentiate between data grid and pickers?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see a big interest in replacing [core] because developers do not really need to read those lines.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is mostly for us, as the team grow I think it should be clear looking at a PR if it impacts the pickers or the datagrid, or the charts, etc...

But the label could work.
That would mean put the "data grid" label on the "[core]" PR that modifies code on the grid packages (same for pickers).

Copy link
Member

@cherniavskii cherniavskii Apr 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would mean put the "data grid" label on the "[core]" PR that modifies code on the grid packages (same for pickers).

Makes total sense to me.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The core repo seems to use [core] only for changes in the infra. I think we used [core] in the past because there was a lot of changes in internal parts. Maybe now, with two components, makes sense to use the prefix of the component affected. The "Add technical doc for pipe processing and family processing" item I would keep with [core] because I understand that [docs] is only for changes that affect the deployed docs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that [docs] is only for changes that affect the deployed docs.

Agree


As for moving everything not infra inside the package sections, I don't have a strong preference

CHANGELOG.md Outdated Show resolved Hide resolved
@flaviendelangle flaviendelangle added the release We are shipping :D label Apr 13, 2022
CHANGELOG.md Outdated Show resolved Hide resolved
@mui-bot
Copy link

mui-bot commented Apr 13, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 270.6 582.4 503.7 444.18 139.238
Sort 100k rows ms 513.9 1,273.7 731 858.44 252.951
Select 100k rows ms 122.9 300.8 178.3 202.4 74.79
Deselect 100k rows ms 108.7 221.3 178.9 169.64 47.456

Generated by 🚫 dangerJS against 8e7848a

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved

### Core

- [core] Add technical doc for pipe processing and family processing (#4322) @flaviendelangle
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see a big interest in replacing [core] because developers do not really need to read those lines.

flaviendelangle and others added 4 commits April 13, 2022 15:00
Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
flaviendelangle and others added 4 commits April 13, 2022 15:01
Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
Co-authored-by: Matheus Wichman <matheushw@outlook.com>
Co-authored-by: Matheus Wichman <matheushw@outlook.com>
Co-authored-by: Matheus Wichman <matheushw@outlook.com>
Co-authored-by: Matheus Wichman <matheushw@outlook.com>
flaviendelangle and others added 2 commits April 13, 2022 15:52
Co-authored-by: Matheus Wichman <matheushw@outlook.com>
CHANGELOG.md Outdated Show resolved Hide resolved
flaviendelangle and others added 2 commits April 14, 2022 14:24
Co-authored-by: Matheus Wichman <matheushw@outlook.com>
@cherniavskii cherniavskii self-assigned this Apr 14, 2022
@cherniavskii cherniavskii merged commit b6e06bb into mui:master Apr 14, 2022
alexfauquette added a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
Co-authored-by: Matheus Wichman <matheushw@outlook.com>
Co-authored-by: Andrew Cherniavskyi <andrew@mui.com>
@flaviendelangle flaviendelangle deleted the v5.9.0 branch November 18, 2022 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release We are shipping :D
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants