Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data grid] Stop using GridEvents enum in @mui/x-data-grid-pro #4696

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Apr 29, 2022

Part of #4684
Follow up on #4685

Will automerge, I don't think it's worth reviewing since it does not change anything concrete and #4685 has been approved.

@flaviendelangle flaviendelangle added the component: data grid This is the name of the generic UI component, not the React module! label Apr 29, 2022
@flaviendelangle flaviendelangle self-assigned this Apr 29, 2022
@mui-bot
Copy link

mui-bot commented Apr 29, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 248.6 429.8 308.2 336.58 73.689
Sort 100k rows ms 427 812 622.1 649.22 144.671
Select 100k rows ms 127.1 360 172.3 202.52 81.121
Deselect 100k rows ms 102.5 191.4 148.1 148.56 28.585

Generated by 🚫 dangerJS against 8bcc0e7

@flaviendelangle flaviendelangle changed the title [data grid] Stop using GridEvents enum in @mui/x-data-grid-pro [data grid] Stop using GridEvents enum in @mui/x-data-grid-pro Apr 29, 2022
@flaviendelangle flaviendelangle changed the title [data grid] Stop using GridEvents enum in @mui/x-data-grid-pro [data grid] Stop using GridEvents enum in @mui/x-data-grid-pro Apr 29, 2022
@flaviendelangle flaviendelangle merged commit 74e08a2 into mui:master Apr 29, 2022
@flaviendelangle flaviendelangle deleted the grid-events-pro branch April 29, 2022 12:52
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants