[pickers] Unify PickersMonth and PickersYear behaviors
#6034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
bug 🐛
flaviendelangle
changed the title
PickersYear behaviors
flaviendelangle
changed the title
PickersYear behaviorsPickersMonth and PickersYear behaviors
|
These are the results for the performance tests:
|
flaviendelangle
commented
Sep 5, 2022
| if (onMonthFocus) { | ||
| onMonthFocus(month); | ||
| } | ||
| const focusMonth = useEventCallback((month: number) => { |
There was a problem hiding this comment.
I used useEventCallback everywhere because we don't have any useEffect listening to callback changes.
And we are passing callbacks to child component and so we were re-rendering every month / year each time those callbacks changed.
LukasTy
reviewed
Sep 6, 2022
LukasTy
reviewed
Sep 6, 2022
LukasTy
approved these changes
Sep 7, 2022
alexfauquette
approved these changes
Sep 7, 2022
|
I have an Argos diff, I'll see if we want to exactly replicate the old UI |
|
I think the diff makes sense |
oliviertassinari
pushed a commit
to oliviertassinari/mui-x
that referenced
this pull request
Sep 12, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5465
Fixes #4459
PickersMonthandPickersYearMonthPickerandYearPickerMonthPickerandYearPicker(requires removing the...otherprops toYearPickerinCalendarPicker)@alexfauquette I hope I did not introduce any regression in your recent improvements.