Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Remove items marked as @deprecated #6505

Merged
merged 23 commits into from
Nov 10, 2022

Conversation

DanailH
Copy link
Member

@DanailH DanailH commented Oct 14, 2022

Fixes #5602
Closes #6698

I had to keep the following deprecations: GridRenderCellParams['api'], GridRenderEditCellParams['api'], GridValueGetterParams['api'] and GridValueFormatterParams['api'] and GridSortCellParams['api']. The reason is that they are being used internally and It getting access to the apiRef otherwise will be difficult.

@DanailH DanailH added breaking change component: data grid This is the name of the generic UI component, not the React module! labels Oct 14, 2022
@DanailH DanailH self-assigned this Oct 14, 2022
@DanailH DanailH changed the title [DataGrid] Remove items marked as deprecated [DataGrid] Remove items marked as @deprecated Oct 14, 2022
@mui-bot
Copy link

mui-bot commented Oct 14, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-6505--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 656.2 915.5 841.6 790.32 106.071
Sort 100k rows ms 580.4 1,104 785.8 857.42 172.416
Select 100k rows ms 187.5 272.2 232.8 226.04 28.923
Deselect 100k rows ms 130.9 268.3 211.1 210.98 50.355

Generated by 🚫 dangerJS against 0aa5e9a

@DanailH DanailH requested a review from cherniavskii October 19, 2022 12:03
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 26, 2022
@github-actions

This comment was marked as outdated.

@DanailH DanailH requested a review from cherniavskii October 26, 2022 07:38
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 26, 2022
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 31, 2022
@github-actions

This comment was marked as outdated.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 2, 2022
DanailH and others added 2 commits November 2, 2022 16:03
…-v5.md

Co-authored-by: Andrew Cherniavskii <andrew.cherniavskii@gmail.com>
Signed-off-by: Danail Hadjiatanasov <hadjiatanasov@gmail.com>
…-v5.md

Co-authored-by: Andrew Cherniavskii <andrew.cherniavskii@gmail.com>
Signed-off-by: Danail Hadjiatanasov <hadjiatanasov@gmail.com>
DanailH and others added 4 commits November 2, 2022 16:04
…-v5.md

Co-authored-by: Andrew Cherniavskii <andrew.cherniavskii@gmail.com>
Signed-off-by: Danail Hadjiatanasov <hadjiatanasov@gmail.com>
…-v5.md

Co-authored-by: Andrew Cherniavskii <andrew.cherniavskii@gmail.com>
Signed-off-by: Danail Hadjiatanasov <hadjiatanasov@gmail.com>
@DanailH DanailH requested a review from cherniavskii November 9, 2022 12:31
DanailH and others added 8 commits November 10, 2022 09:16
…-v5.md

Co-authored-by: Andrew Cherniavskii <andrew.cherniavskii@gmail.com>
Signed-off-by: Danail Hadjiatanasov <hadjiatanasov@gmail.com>
…-v5.md

Co-authored-by: Andrew Cherniavskii <andrew.cherniavskii@gmail.com>
Signed-off-by: Danail Hadjiatanasov <hadjiatanasov@gmail.com>
…-v5.md

Co-authored-by: Andrew Cherniavskii <andrew.cherniavskii@gmail.com>
Signed-off-by: Danail Hadjiatanasov <hadjiatanasov@gmail.com>
…-v5.md

Co-authored-by: Andrew Cherniavskii <andrew.cherniavskii@gmail.com>
Signed-off-by: Danail Hadjiatanasov <hadjiatanasov@gmail.com>
…-v5.md

Co-authored-by: Andrew Cherniavskii <andrew.cherniavskii@gmail.com>
Signed-off-by: Danail Hadjiatanasov <hadjiatanasov@gmail.com>
…-v5.md

Co-authored-by: Andrew Cherniavskii <andrew.cherniavskii@gmail.com>
Signed-off-by: Danail Hadjiatanasov <hadjiatanasov@gmail.com>
…-v5.md

Co-authored-by: Andrew Cherniavskii <andrew.cherniavskii@gmail.com>
Signed-off-by: Danail Hadjiatanasov <hadjiatanasov@gmail.com>
@DanailH DanailH requested a review from cherniavskii November 10, 2022 07:23
@DanailH DanailH merged commit f35b6f5 into mui:next Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
4 participants