Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix typo in Export page #6848

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Conversation

m4theushw
Copy link
Member

@m4theushw m4theushw added the docs Improvements or additions to the documentation label Nov 14, 2022
@mui-bot
Copy link

mui-bot commented Nov 14, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-6848--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 682.7 1,214.1 682.7 930.78 230.939
Sort 100k rows ms 618.3 1,416.9 1,416.9 1,020.54 287.489
Select 100k rows ms 194 378.5 282.8 279 68.044
Deselect 100k rows ms 133.1 283.8 217.8 213.02 52.82

Generated by 🚫 dangerJS against fe62e65

@@ -135,7 +137,7 @@ You can provide a [`valueFormatter`](/x/react-data-grid/column-definition/#value
### File encoding

You can use `csvOptions` to specify the format of the export, such as the `delimiter` character used to separate fields, the `fileName`, or `utf8WithBom` to prefix the exported file with UTF-8 Byte Order Mark (BOM).
For more details on these options, please visit the [`csvOptions` api page](/x/api/data-grid/grid-csv-export-options/).
For more details on these options, please visit the [`csvOptions` API page](/x/api/data-grid/grid-csv-export-options/).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me think that we could add a rule to automatically detect those inconsistencies:
https://vale.sh/docs/topics/styles/#substitution

If you have other typo in mind you face frequently, add them in comment I will create a first rule with them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants