[DataGrid] Rename ErrorOverlay to GridErrorOverlay
#6946
Conversation
MBilalShafi
added
breaking change
component: data grid
MBilalShafi
requested review from
flaviendelangle,
DanailH,
cherniavskii and
m4theushw
These are the results for the performance tests:
|
| export const ErrorOverlay = React.forwardRef<HTMLDivElement, ErrorOverlayProps>( | ||
| function ErrorOverlay(props: ErrorOverlayProps, ref) { | ||
| export const GridErrorOverlay = React.forwardRef<HTMLDivElement, GridErrorOverlayProps>( | ||
| function GridErrorOverlay(props, ref) { |
There was a problem hiding this comment.
We should include the renamed exports in the migration guide
There was a problem hiding this comment.
This file was not exported previously, only being used in slots, may be export it then?
But as it will be a new export it won't go in migration guide, right?
There was a problem hiding this comment.
Oh, indeed.
No need to export it then
There was a problem hiding this comment.
Just to mention here. The user from #6800 reused the ErrorOverlayProps interface by importing directly this file. I don't think we need update the migration guide but we could add a comment in case he wants to try v6.
There was a problem hiding this comment.
Ok, thanks for the update!
m4theushw
changed the title
ErrorOverlay to GridErrorOverlay
| export const ErrorOverlay = React.forwardRef<HTMLDivElement, ErrorOverlayProps>( | ||
| function ErrorOverlay(props: ErrorOverlayProps, ref) { | ||
| export const GridErrorOverlay = React.forwardRef<HTMLDivElement, GridErrorOverlayProps>( | ||
| function GridErrorOverlay(props, ref) { |
There was a problem hiding this comment.
Just to mention here. The user from #6800 reused the ErrorOverlayProps interface by importing directly this file. I don't think we need update the migration guide but we could add a comment in case he wants to try v6.
cherniavskii
changed the title
ErrorOverlay to GridErrorOverlayErrorOverlay to GridErrorOverlay
Closes #5609