Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Add GridCell change in migration guide #7087

Merged
merged 3 commits into from
Dec 5, 2022
Merged

[DataGrid] Add GridCell change in migration guide #7087

merged 3 commits into from
Dec 5, 2022

Conversation

MBilalShafi
Copy link
Member

Change mentioned in #7023 (comment)

@MBilalShafi MBilalShafi added docs Improvements or additions to the documentation breaking change component: data grid This is the name of the generic UI component, not the React module! v6.x labels Dec 4, 2022
@MBilalShafi MBilalShafi self-assigned this Dec 4, 2022
@MBilalShafi MBilalShafi mentioned this pull request Dec 4, 2022
Closed
16 tasks
@mui-bot
Copy link

mui-bot commented Dec 4, 2022 •
edited
Loading

Messages
📖 Netlify deploy preview: https://deploy-preview-7087--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 868.1 1,276.9 1,276.9 1,028.5 154.929
Sort 100k rows ms 983.2 1,318.7 1,316.2 1,185.44 130.089
Select 100k rows ms 279.4 457.2 309 331.88 64.565
Deselect 100k rows ms 218.2 300.3 283.5 265.62 31.436

Generated by 🚫 dangerJS against d69ac12

@MBilalShafi MBilalShafi changed the title [DataGrid] Add GridCell change in migration guide [DataGrid] Add GridCell change in migration guide Dec 4, 2022
@MBilalShafi @cherniavskii
Update docs/data/migration/migration-data-grid-v5/migration-data-grid…
d69ac12 
…-v5.md

Co-authored-by: Andrew Cherniavskii <andrew.cherniavskii@gmail.com>
Signed-off-by: Bilal Shafi <bilalshafidev@gmail.com>
@MBilalShafi MBilalShafi merged commit 1ff32ae into mui:next Dec 5, 2022
@MBilalShafi MBilalShafi deleted the updates-migration-guide branch December 5, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cherniavskii cherniavskii cherniavskii approved these changes

@DanailH DanailH Awaiting requested review from DanailH

Assignees

@MBilalShafi MBilalShafi

Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation v6.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MBilalShafi @mui-bot @cherniavskii