Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGridPro] Fix wrong border color on skeleton cells #7202

Merged
merged 1 commit into from
Dec 14, 2022
Merged

[DataGridPro] Fix wrong border color on skeleton cells #7202

merged 1 commit into from
Dec 14, 2022

Conversation

cherniavskii
Copy link
Member

Fixes small visual bug introduced in #4197

Before:
Screenshot 2022-12-14 at 15 47 26
After:
Screenshot 2022-12-14 at 15 47 08

@cherniavskii cherniavskii added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Rendering layout Related to the data grid Rendering engine labels Dec 14, 2022
@mui-bot
Copy link

mui-bot commented Dec 14, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-7202--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 653.3 1,204.3 709.1 858.46 203.106
Sort 100k rows ms 608.2 1,106 608.2 891.08 167.755
Select 100k rows ms 204.7 386.1 308.7 294.58 60.303
Deselect 100k rows ms 159.1 232.9 182.2 196.06 27.926

Generated by 🚫 dangerJS against 6ae6377

@cherniavskii
Copy link
Member Author

Merging it without approvals since it's a trivial change

@cherniavskii cherniavskii marked this pull request as ready for review December 14, 2022 15:46
@cherniavskii cherniavskii merged commit 73eb00b into mui:next Dec 14, 2022
@cherniavskii cherniavskii deleted the fix-cell-skeleton-border branch December 14, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Rendering layout Related to the data grid Rendering engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cherniavskii @mui-bot