[DataGrid] Stop exporting editing selector #7456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4theushw
added
the
component: data grid
These are the results for the performance tests:
|
| @@ -49,6 +49,7 @@ export { | |||
| preferencePanelStateInitializer, | |||
| } from '../hooks/features/preferencesPanel/useGridPreferencesPanel'; | |||
| export { useGridEditing, editingStateInitializer } from '../hooks/features/editing/useGridEditing'; | |||
| export * from '../hooks/features/editing/gridEditingSelectors'; | |||
There was a problem hiding this comment.
I tend to avoid the "export all" pattern in the internal to make keep clear what we are exporting as private and prioritize public imports.
flaviendelangle
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3287
Changelog
Breaking changes
gridEditRowsStateSelectorselector was removed.