Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGridPremium] Create aggregation footer row with isAutoGenerated: true #7681

Merged
merged 3 commits into from
Jan 25, 2023

Conversation

m4theushw
Copy link
Member

@m4theushw m4theushw commented Jan 23, 2023

Fixes #7673

Before: https://codesandbox.io/s/brave-euler-x271hy?file=/demo.tsx
After: https://codesandbox.io/s/nifty-field-f6k5ol?file=/demo.tsx

The row added for the aggregation footer has isAutoGenerated: false. Because of that, it doesn't fall into the condition below

if (params.rowNode.isAutoGenerated) {
return '';
}

In the next branch, isAutoGenerated: true was added in #4927 so I won't backport this PR.

@mui-bot
Copy link

mui-bot commented Jan 23, 2023

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 472.9 759.1 713.4 634.88 124.124
Sort 100k rows ms 696.4 1,137.2 800.6 860.44 147.324
Select 100k rows ms 209.5 275.9 259 249.14 25.661
Deselect 100k rows ms 152.1 217.6 203.3 192.96 22.915

Generated by 🚫 dangerJS against 96d425a

@m4theushw m4theushw merged commit befbab4 into mui:master Jan 25, 2023
@m4theushw m4theushw deleted the aggregation-footer-is-auto-generated branch January 25, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants