[DataGrid] Allow to pass props to the TrapFocus inside the panel wrapper
#7733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are the results for the performance tests:
|
Vivek-Prajapatii
changed the title
oliviertassinari
added
the
component: data grid
| MUIStyledCommonProps<Theme> {} | ||
|
|
||
| const GridPanelWrapper = React.forwardRef<HTMLDivElement, GridPanelWrapperProps>( | ||
| function GridPanelWrapper(props, ref) { | ||
| const { className, ...other } = props; | ||
| const { className, TrapFocusProps: TrapFocusPropsProps, ...other } = props; |
There was a problem hiding this comment.
I wonder about the convention used in this context. Would it make more sense with?
Suggested change
| const { className, TrapFocusProps: TrapFocusPropsProps, ...other } = props; | |
| const { className, slotProps, ...other } = props; |
It would become:
<DataGrid
componentsProps={{ filterPanel: { slotProps: { trapFocus: { disableRestoreFocus: true } } } }}
/>
m4theushw
reviewed
Jan 31, 2023
| const rootProps = useGridRootProps(); | ||
| const ownerState = { classes: rootProps.classes }; | ||
| const classes = useUtilityClasses(ownerState); | ||
|
|
||
| return ( | ||
| <TrapFocus open disableEnforceFocus isEnabled={isEnabled}> | ||
| <TrapFocus open disableEnforceFocus isEnabled={isEnabled} {...slotProps}> |
There was a problem hiding this comment.
To support the example usage from #7733 (comment), we need to spread slotProps.trapFocus instead.
Suggested change
| <TrapFocus open disableEnforceFocus isEnabled={isEnabled} {...slotProps}> | |
| <TrapFocus open disableEnforceFocus isEnabled={isEnabled} {...slotProps.trapFocus}> |
You also need to do slotProps = {} when extracting the prop from props above.
m4theushw
changed the title
TrapFocus inside panel wrapper
m4theushw
changed the title
TrapFocus inside panel wrapper
m4theushw
changed the title
m4theushw
changed the title
TrapFocus inside the panel wrapper
m4theushw
added
the
needs cherry-pick
m4theushw
added a commit
to m4theushw/mui-x
that referenced
this pull request
Feb 10, 2023
…apper (mui#7733) Co-authored-by: Matheus Wichman <matheushw@outlook.com>
This was referenced Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for #7044