Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pickers] Ditch pickers skipLibCheck #7808

Merged
merged 3 commits into from
Feb 9, 2023

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Feb 2, 2023

Related to dmtrKovalenko/date-io#52

If we were able to remove skipLibCheck: "true", we would avoid most issues like #7779

Currently, our authored .d.ts files are ignored by tsc and thus, any issues in them can slip unnoticed by both human eye as well as CI steps.

It's not the most robust solution as package bumps might need changes, but IMHO it's worth the added type safety in our authored d.ts files. 🙈 🤞

  • Fix @date-io adapters type declaration module names to be uniquely scoped (seems like it should originally be something like that)
  • Rename date-fns-jalali duplicated typing type names to avoid tsc issues

@LukasTy LukasTy added typescript component: pickers This is the name of the generic UI component, not the React module! labels Feb 2, 2023
@LukasTy LukasTy self-assigned this Feb 2, 2023
@mui-bot
Copy link

mui-bot commented Feb 2, 2023

Messages
📖 Netlify deploy preview: https://deploy-preview-7808--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 689.6 1,297.9 689.6 938.24 231.399
Sort 100k rows ms 821.1 1,337.8 1,337.8 1,142 202.737
Select 100k rows ms 203.8 333.2 289.3 271.14 52.382
Deselect 100k rows ms 222.5 357.3 242.8 271.08 53.61

Generated by 🚫 dangerJS against 034c288

Copy link
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving the adapters to our repo will allow us to remove those patches in the future.

@LukasTy LukasTy added the external dependency Blocked by external dependency, we can’t do anything about it label Feb 6, 2023
@LukasTy LukasTy marked this pull request as ready for review February 6, 2023 18:06
@LukasTy LukasTy merged commit 4b8cce1 into mui:next Feb 9, 2023
@LukasTy LukasTy deleted the ditch-pickers-skip-lib-check branch February 9, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pickers This is the name of the generic UI component, not the React module! external dependency Blocked by external dependency, we can’t do anything about it typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants