Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pickers] Update pickers when new value has a distinct timezone #7853

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

alexfauquette
Copy link
Member

Fix #7833

@alexfauquette alexfauquette added the bug 🐛 Something doesn't work label Feb 8, 2023
@mui-bot
Copy link

mui-bot commented Feb 8, 2023

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 520.8 817.4 648.8 676.22 114.653
Sort 100k rows ms 570.5 1,128.5 570.5 859.04 222.017
Select 100k rows ms 163.3 250.4 218.5 210.14 28.5
Deselect 100k rows ms 148.3 193.7 191.7 176.18 20.413

Generated by 🚫 dangerJS against 145b7cf

Copy link
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a similar problem on the new fields or is it purely a mask issue ?

@alexfauquette
Copy link
Member Author

alexfauquette commented Feb 8, 2023

Good points. It does not seem to be a problem in v6 @stem-ui If you could check v6 is working nice. Here is a codesandbox where you can switch between UTC and LA time zone. The field is correctly responding

https://codesandbox.io/s/friendly-wilbur-pjudi8?file=/demo.tsx

Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 Could we maybe add a test case asserting this behaviour and potentially forward-porting it to next as well? 🤔

@stem-ui
Copy link

stem-ui commented Feb 9, 2023

@alexfauquette , confirmed not an issue in v6

https://codesandbox.io/s/elated-austin-pld75s?file=/demo.tsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants