Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pickers] Document and deprecate onClose callback on static pickers #8021

Merged
merged 6 commits into from
Feb 24, 2023
Merged

[pickers] Document and deprecate onClose callback on static pickers #8021

merged 6 commits into from
Feb 24, 2023

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Feb 23, 2023 •
edited
Loading

Fixes #7895

@LukasTy LukasTy added docs Improvements or additions to the documentation typescript component: pickers This is the name of the generic UI component, not the React module! labels Feb 23, 2023
@LukasTy LukasTy self-assigned this Feb 23, 2023
@mui-bot
Copy link

mui-bot commented Feb 23, 2023 •
edited
Loading

Messages
📖 Netlify deploy preview: https://deploy-preview-8021--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 672 1,174.9 672 913.86 193.005
Sort 100k rows ms 673.2 1,278.7 1,278.7 1,011.68 250.786
Select 100k rows ms 227.4 370.9 295.8 298.64 47.156
Deselect 100k rows ms 169 326 272.7 263.72 53.855

Generated by 🚫 dangerJS against 1f62ad6

LukasTy
LukasTy commented Feb 23, 2023
View reviewed changes
packages/x-date-pickers/src/StaticDatePicker/StaticDatePicker.types.ts Outdated
@@ -20,7 +20,7 @@ export interface StaticDatePickerSlotsComponentsProps<TDate>

export interface StaticDatePickerProps<TDate>
extends BaseDatePickerProps<TDate>,
MakeOptional<StaticOnlyPickerProps, 'displayStaticWrapperAs'> {
StaticOnlyPickerProps {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flaviendelangle The usage of MakeOptional here was causing the onClose to lose the deprecated styling in VsCode IDE.
What's the case with WebStorm? 🤔

Before:
Screenshot 2023-02-23 at 14 57 29

After:
Screenshot 2023-02-23 at 14 57 49

@LukasTy LukasTy merged commit 89c3137 into mui:next Feb 24, 2023
@LukasTy LukasTy deleted the document-and-deprecate-static-on-close branch February 24, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaviendelangle flaviendelangle Awaiting requested review from flaviendelangle

Assignees

@LukasTy LukasTy

Labels
component: pickers This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[pickers] Static picker versions call onClose, but it's not documented
3 participants
@LukasTy @mui-bot @flaviendelangle