Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Register getLocaleText synchronously #8029

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

m4theushw
Copy link
Member

@m4theushw m4theushw commented Feb 23, 2023

@m4theushw m4theushw added the component: data grid This is the name of the generic UI component, not the React module! label Feb 23, 2023
@mui-bot
Copy link

mui-bot commented Feb 23, 2023

Messages
📖 Netlify deploy preview: https://deploy-preview-8029--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 735.6 1,019.6 824.8 897.7 106.207
Sort 100k rows ms 817 1,143.7 817 998.32 126.264
Select 100k rows ms 207.4 317 299.2 283.54 40.187
Deselect 100k rows ms 231.2 351.4 293.6 293.32 38.187

Generated by 🚫 dangerJS against e0b1dec

@cherniavskii cherniavskii added the bug 🐛 Something doesn't work label Feb 24, 2023
@m4theushw m4theushw added the needs cherry-pick The PR should be cherry-picked to master after merge label Feb 27, 2023
@m4theushw m4theushw merged commit 3149c0a into mui:next Feb 27, 2023
@m4theushw m4theushw deleted the get-locale-text-fix branch February 27, 2023 22:49
m4theushw added a commit to m4theushw/mui-x that referenced this pull request Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! needs cherry-pick The PR should be cherry-picked to master after merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DataGrid] localeText update does not re-render the grid with new translation
3 participants