[pickers] Add support for UTC on moment adapter #8031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
the
component: pickers
flaviendelangle
commented
Feb 24, 2023
| @@ -90,4 +94,12 @@ export class AdapterMoment | |||
| public getWeekNumber = (date: defaultMoment.Moment) => { | |||
| return date.week(); | |||
| }; | |||
|
|
|||
| public getWeekdays = () => { | |||
There was a problem hiding this comment.
I think I'll write an RFC in the coming weeks, proposing to finally migrate all the adapters to our repository.
We are duplicating more and more logic...
These are the results for the performance tests:
|
alexfauquette
approved these changes
Feb 27, 2023
Comment on lines
+235
to
+239
| value={moment.utc()} | ||
| minDate={moment.utc().startOf('month')} | ||
| // ❌ Invalid props | ||
| value={moment()} | ||
| minDate={moment().startOf('month')} |
There was a problem hiding this comment.
Adding an empty line could simplify the understanding at first look (without having to stop to think about it)
Suggested change
| value={moment.utc()} | |
| minDate={moment.utc().startOf('month')} | |
| // ❌ Invalid props | |
| value={moment()} | |
| minDate={moment().startOf('month')} | |
| value={moment.utc()} | |
| minDate={moment.utc().startOf('month')} | |
| // ❌ Invalid props | |
| value={moment()} | |
| minDate={moment().startOf('month')} |
There was a problem hiding this comment.
Prettier automatically removes it, I agree that it would be nice otherwise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doc preview
moment.utcdoes not have the static properties (same issue we had fordayjs).I think we could update the JSDoc of
dateLibInstanceto say that it's the instance we use to parse dates, not the instance we use for the rest.