Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Clarify the MIT license restriction for grid pagination #8045

Merged
merged 2 commits into from
Feb 26, 2023
Merged

[docs] Clarify the MIT license restriction for grid pagination #8045

merged 2 commits into from
Feb 26, 2023

Conversation

arunkp
Copy link
Contributor

@arunkp arunkp commented Feb 25, 2023

No description provided.

@mui-bot
Copy link

mui-bot commented Feb 25, 2023 •
edited
Loading

Messages
📖 Netlify deploy preview: https://deploy-preview-8045--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 598.6 833.6 668.1 697.92 94.69
Sort 100k rows ms 584.2 1,021.7 800.8 823.28 140.733
Select 100k rows ms 184.4 358.5 224.4 245.88 59.15
Deselect 100k rows ms 143.2 272.1 176.1 188.54 48.018

Generated by 🚫 dangerJS against 490f3d6

@arunkp @oliviertassinari
Typo Fix
3ca3b71 
Signed-off-by: Arun Rao <arunraokalya@gmail.com>
@oliviertassinari oliviertassinari changed the base branch from master to next February 25, 2023 17:09
@oliviertassinari oliviertassinari changed the title Typo Fix [docs] Clarify what MIT refers to Feb 25, 2023
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Feb 25, 2023
@oliviertassinari
Copy link
Member

Thanks, I have pushed an extra commit to be clearer.

@arunkp arunkp closed this Feb 25, 2023
@arunkp arunkp reopened this Feb 25, 2023
@arunkp
Copy link
Contributor Author

arunkp commented Feb 25, 2023

Thanks, yes that looks much better.

@MBilalShafi MBilalShafi added the component: data grid This is the name of the generic UI component, not the React module! label Feb 26, 2023
MBilalShafi
MBilalShafi approved these changes Feb 26, 2023
View reviewed changes
Copy link
Member

@MBilalShafi MBilalShafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.

@MBilalShafi MBilalShafi changed the title [docs] Clarify what MIT refers to [docs] Clarify the MIT license restrictions for pagination options Feb 26, 2023
@MBilalShafi MBilalShafi changed the title [docs] Clarify the MIT license restrictions for pagination options [docs] Clarify the MIT license restriction for grid pagination Feb 26, 2023
@MBilalShafi MBilalShafi merged commit 16b0165 into mui:next Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MBilalShafi MBilalShafi MBilalShafi approved these changes

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arunkp @mui-bot @oliviertassinari @MBilalShafi