Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix typo bellow -> below #8080

Merged
merged 5 commits into from
Mar 3, 2023
Merged

[docs] Fix typo bellow -> below #8080

merged 5 commits into from
Mar 3, 2023

Conversation

TheBox193
Copy link
Contributor

Changes

  • Fix typo bellow -> below

Questions

  • What scripts would be need to be run to re-generate the rest of the docs, etc?

Signed-off-by: Sir.Nathan (Jonathan Stassen) <jonathan@waterclick.tech>
@mui-bot
Copy link

mui-bot commented Feb 28, 2023

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-8080--material-ui-x.netlify.app/

Updated pages

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 803.3 1,273.1 1,273.1 988.94 167.692
Sort 100k rows ms 774.9 1,326 1,235.2 1,111.06 196.572
Select 100k rows ms 271.7 380.5 317 324.38 37.355
Deselect 100k rows ms 164.2 323.5 256 241.7 56.423

Generated by 🚫 dangerJS against 81733a3

@LukasTy
Copy link
Member

LukasTy commented Mar 1, 2023

Thank you for your contribution! 🙏

What scripts would be need to be run to re-generate the rest of the docs, etc?

You need to find the file where this string is defined as JSDoc for this given slot and update it only there. In this case it seems that PickersLayout.types.ts is the place.
Running yarn docs:api should take care of updating all the necessary doc "translations" files. 😉

@LukasTy LukasTy added docs Improvements or additions to the documentation component: pickers This is the name of the generic UI component, not the React module! labels Mar 1, 2023
@LukasTy LukasTy changed the title Fix typo bellow -> below [ docs] Fix typo bellow -> below Mar 1, 2023
@LukasTy LukasTy changed the title [ docs] Fix typo bellow -> below [docs] Fix typo bellow -> below Mar 1, 2023
@alexfauquette
Copy link
Member

I allowed myself to add a commit to add bellow -> below in our vale config to prevent us from adding new "bellow" latter

@alexfauquette alexfauquette merged commit b1e91ba into mui:next Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pickers This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants